fix: implement missing utilities and fix edge-case bugs#209
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - string-utils: implement truncate (word-boundary, ellipsis-aware) and fix wordCount whitespace handling - task-manager: implement remove, update, and sortBy - date-utils: fix off-by-one in relative day rounding (Math.round) - validator: accept long TLDs in isEmail and URLs with ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. The suite now passes 60/60 (was 44/60). No test files modified, no dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0(previously returnedInfinity).src/string-utils.ts— implementedtruncate(word-boundary aware, ellipsis counts towardmaxLength, handles tiny limits) and fixedwordCountto split on\s+.src/task-manager.ts— implemented the missingremove,update, andsortBymethods (remove/updatereturnfalsefor unknown ids;sortBysupports priority and createdAt ordering).src/date-utils.ts— fixed off-by-one informatRelativeby usingMath.roundfor the day count (36h → "2 days ago").src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts URLs with a port (e.g.http://localhost:3000).Verification
bun test→ 60 pass / 0 fail.Assumptions / notes
sortBy("status")uses alphabetical (localeCompare) ordering, as no explicit status order is specified by the tests.truncatereturns a raw slice without an ellipsis whenmaxLength <= ellipsis.length, matching the tiny-limit test expectations.